[PATCH] D17883: [ASAN] Add support for mips/mips64 android

Alexey Samsonov via llvm-commits llvm-commits at lists.llvm.org
Tue Mar 15 11:54:00 PDT 2016

samsonov accepted this revision.
samsonov added a comment.
This revision is now accepted and ready to land.

LGTM after addressing one minor comment below. Thanks!

Comment at: lib/sanitizer_common/sanitizer_linux_libcdep.cc:171
@@ -171,3 +170,3 @@
 // head structure. It lies before the static tls blocks.
 static uptr TlsPreTcbSize() {
 # if defined(__mips__)
Uhm, no, this function is only used in ThreadSelf(). Let's move it away from here, and right before ThreadSelf() definition below.



More information about the llvm-commits mailing list