[PATCH] D18164: [tsan] Do not instrument reads/writes to instruction profile counters.

Dmitry Vyukov via llvm-commits llvm-commits at lists.llvm.org
Tue Mar 15 11:41:40 PDT 2016

dvyukov added a comment.

> It is not about this assumption, but more about racy counter updates not being a problem practically

Choosing an incorrect code all others equal does not look like the right approach to me.

> It might -- at least we should measure it. Note that instrumentation run is already pretty slow, so we need to be careful not to regress it.

Again, is that's the case, that's a very real bug in llvm codegen that needs to be fixed. Patching all uses of atomic operations in the world to work around that bug is not going to scale (and just wrong).


More information about the llvm-commits mailing list