[lld] r263543 - [COFF] Don't hard-code the load configuration size

David Majnemer via llvm-commits llvm-commits at lists.llvm.org
Tue Mar 15 09:52:39 PDT 2016


Fixed in r263558.

On Tue, Mar 15, 2016 at 9:20 AM, David Majnemer <david.majnemer at gmail.com>
wrote:

> Reverting my change but keeping my test modifications results in LLD
> failing under ASan.  Looks like a latent bug, taking a closer look.
>
>
> On Tue, Mar 15, 2016 at 7:49 AM, George Rimar <grimar at accesssoftek.com>
> wrote:
>
>> >[COFF] Don't hard-code the load configuration size
>> >...
>> >Modified:
>> >   lld/trunk/COFF/Chunks.h
>> >   lld/trunk/COFF/Writer.cpp
>> >   lld/trunk/test/COFF/loadcfg.ll
>> >   lld/trunk/test/COFF/loadcfg.test
>> >   lld/trunk/test/COFF/loadcfg32.test
>>
>> Hi David,
>>
>> I think something here broke buildbot:
>> http://lab.llvm.org:8011/builders/llvm-clang-lld-x86_64-scei-ps4-windows10pro-fast/builds/1758
>> .
>> It is blaming me now, but my changes were relative to ELF and not to
>> COFF. I am observing the same fail locally, and when I revert this patch
>> then
>> tests pass fine for me.
>>
>> George.
>
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20160315/03aef589/attachment.html>


More information about the llvm-commits mailing list