[PATCH] D18168: [NVVM] Remove noduplicate attribute from synchronizing intrinsics.

[Justin Lebar via llvm-commits]

jlebar created this revision.
jlebar added a reviewer: jholewinski.
jlebar added a subscriber: llvm-commits.
Herald added a subscriber: jholewinski.

I've completed my audit of all the code that looks at noduplicate and
added handling of convergent where appropriate, so we no longer need
noduplicate on these intrinsics.

http://reviews.llvm.org/D18168

Files:
  include/llvm/IR/IntrinsicsNVVM.td
  test/Feature/intrinsic-noduplicate.ll

Index: test/Feature/intrinsic-noduplicate.ll
===================================================================
--- test/Feature/intrinsic-noduplicate.ll
+++ test/Feature/intrinsic-noduplicate.ll
@@ -1,9 +1,9 @@
 ; RUN: llvm-as < %s | llvm-dis | FileCheck %s
 
-; Make sure LLVM knows about the convergent and noduplicate attributes on the
+; Make sure LLVM knows about the convergent attribute on the
 ; llvm.cuda.syncthreads intrinsic.
 
 declare void @llvm.cuda.syncthreads()
 
 ; CHECK: declare void @llvm.cuda.syncthreads() #[[ATTRNUM:[0-9]+]]
-; CHECK: attributes #[[ATTRNUM]] = { convergent noduplicate nounwind }
+; CHECK: attributes #[[ATTRNUM]] = { convergent nounwind }
Index: include/llvm/IR/IntrinsicsNVVM.td
===================================================================
--- include/llvm/IR/IntrinsicsNVVM.td
+++ include/llvm/IR/IntrinsicsNVVM.td
@@ -729,20 +729,16 @@
                                       [IntrReadWriteArgMem, NoCapture<0>]>;
 
 // Bar.Sync
-//
-// TODO: Remove NoDuplicate here after fixing up LLVM to handle convergent
-// properly.  See discussion in http://reviews.llvm.org/D16941 and
-// http://reviews.llvm.org/D12246.
   def int_cuda_syncthreads : GCCBuiltin<"__syncthreads">,
-      Intrinsic<[], [], [IntrNoDuplicate, IntrConvergent]>;
+      Intrinsic<[], [], [IntrConvergent]>;
   def int_nvvm_barrier0 : GCCBuiltin<"__nvvm_bar0">,
-      Intrinsic<[], [], [IntrNoDuplicate, IntrConvergent]>;
+      Intrinsic<[], [], [IntrConvergent]>;
   def int_nvvm_barrier0_popc : GCCBuiltin<"__nvvm_bar0_popc">,
-      Intrinsic<[llvm_i32_ty], [llvm_i32_ty], [IntrNoDuplicate, IntrConvergent]>;
+      Intrinsic<[llvm_i32_ty], [llvm_i32_ty], [IntrConvergent]>;
   def int_nvvm_barrier0_and : GCCBuiltin<"__nvvm_bar0_and">,
-      Intrinsic<[llvm_i32_ty], [llvm_i32_ty], [IntrNoDuplicate, IntrConvergent]>;
+      Intrinsic<[llvm_i32_ty], [llvm_i32_ty], [IntrConvergent]>;
   def int_nvvm_barrier0_or : GCCBuiltin<"__nvvm_bar0_or">,
-      Intrinsic<[llvm_i32_ty], [llvm_i32_ty], [IntrNoDuplicate, IntrConvergent]>;
+      Intrinsic<[llvm_i32_ty], [llvm_i32_ty], [IntrConvergent]>;
 
   // Membar
   def int_nvvm_membar_cta : GCCBuiltin<"__nvvm_membar_cta">,


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D18168.50685.patch
Type: text/x-patch
Size: 2198 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20160315/35977388/attachment.bin>