[PATCH] D18064: AMDGPU/SI: Implement GroupStaticSize Intrinsic for Dynamic LDS

Matt Arsenault via llvm-commits llvm-commits at lists.llvm.org
Mon Mar 14 15:44:23 PDT 2016

arsenm added inline comments.

Comment at: lib/Target/AMDGPU/SIISelLowering.cpp:1064
@@ +1063,3 @@
+      .addOperand(MI->getOperand(0))
+      .addImm(MFI->LDSSize);
+    MI->eraseFromParent();
tstellarAMD wrote:
> I don't think this will work if we call this intrinsic in the entry block and then the LDS variables are used in different blocks.  Can you add a test case for this and then fix it if it doesn't work.
This is ok because this is called by the ExpandISelPseudos pass which runs on the completed MachineFunction


More information about the llvm-commits mailing list