[PATCH] D18160: [MC] Rename TLSCALL as it's not ARM specific

Davide Italiano via llvm-commits llvm-commits at lists.llvm.org
Mon Mar 14 14:33:00 PDT 2016


davide created this revision.
davide added reviewers: rafael, echristo, compnerd.
davide added a subscriber: llvm-commits.
Herald added subscribers: rengolin, aemerson.

`MCSymbolRefExpr` variant kind for TLSCALL is prefixed with _ARM_ since it was originally implemented.
I'm currently implementing the X86_64 version(s) described here http://www.fsfla.org/~lxoliva/writeups/TLS/RFC-TLSDESC-x86.txt and noticed that the assembler for both of them is:

symbol at TLSCALL(%register)

I think it makes sense to rename VK_ARM_TLSCALL to VK_TLSCALL (this may also be true for TLSDESC) and implement the correct semantic action in the machine-dependent code. Any objections?

http://reviews.llvm.org/D18160

Files:
  include/llvm/MC/MCExpr.h
  lib/MC/MCExpr.cpp
  lib/Target/ARM/MCTargetDesc/ARMAsmBackend.cpp
  lib/Target/ARM/MCTargetDesc/ARMELFObjectWriter.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D18160.50647.patch
Type: text/x-patch
Size: 3874 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20160314/5d090164/attachment.bin>


More information about the llvm-commits mailing list