[PATCH] D18064: AMDGPU/SI: Implement GroupStaticSize Intrinsic for Dynamic LDS

Tom Stellard via llvm-commits llvm-commits at lists.llvm.org
Mon Mar 14 13:44:58 PDT 2016

tstellarAMD added inline comments.

Comment at: lib/Target/AMDGPU/SIISelLowering.cpp:1064
@@ +1063,3 @@
+      .addOperand(MI->getOperand(0))
+      .addImm(MFI->LDSSize);
+    MI->eraseFromParent();
I don't think this will work if we call this intrinsic in the entry block and then the LDS variables are used in different blocks.  Can you add a test case for this and then fix it if it doesn't work.


More information about the llvm-commits mailing list