[PATCH] D18133: allow branch weight metadata on select instructions (PR26636)

[David Li via llvm-commits]

davidxl accepted this revision.
davidxl added a comment.
This revision is now accepted and ready to land.

lgtm.


================
Comment at: include/llvm/IR/IRBuilder.h:1571
@@ -1570,2 +1570,3 @@
 
   Value *CreateSelect(Value *C, Value *True, Value *False,
+                      const Twine &Name = "", MDNode *ProfWeights = nullptr) {
----------------
yes, this test case is what I am looking for -- I think it should be part of this patch (though the branch instruction meta test testing can be added in a separate patch though I won't mind either way).

I also suggesting changing the file name to 'profile-meta.ll'


http://reviews.llvm.org/D18133