[test-suite] r263456 - cmake/caches: Add some comments, more aggressive release mode

[Quentin Colombet via llvm-commits]

Hi Matthias,

> On Mar 14, 2016, at 11:12 AM, Matthias Braun via llvm-commits <llvm-commits at lists.llvm.org> wrote:
> 
> Author: matze
> Date: Mon Mar 14 13:12:36 2016
> New Revision: 263456
> 
> URL: http://llvm.org/viewvc/llvm-project?rev=263456&view=rev
> Log:
> cmake/caches: Add some comments, more aggressive release mode
> 
> Added:
>    test-suite/trunk/cmake/caches/Release_Haswell.cmake
> Modified:
>    test-suite/trunk/cmake/caches/Debug.cmake
>    test-suite/trunk/cmake/caches/Release.cmake
> 
> Modified: test-suite/trunk/cmake/caches/Debug.cmake
> URL: http://llvm.org/viewvc/llvm-project/test-suite/trunk/cmake/caches/Debug.cmake?rev=263456&r1=263455&r2=263456&view=diff
> ==============================================================================
> --- test-suite/trunk/cmake/caches/Debug.cmake (original)
> +++ test-suite/trunk/cmake/caches/Debug.cmake Mon Mar 14 13:12:36 2016
> @@ -1,3 +1,5 @@
> +# Lowest optimization level and maximum debug information; A typical developer
> +# configuration.
> +set(CMAKE_BUILD_TYPE "Debug" CACHE STRING "")
> set(CMAKE_C_FLAGS_DEBUG "-O0 -g" CACHE STRING "")
> set(CMAKE_CXX_FLAGS_DEBUG "-O0 -g" CACHE STRING "")
> -set(CMAKE_BUILD_TYPE "Debug" CACHE STRING "")
> 
> Modified: test-suite/trunk/cmake/caches/Release.cmake
> URL: http://llvm.org/viewvc/llvm-project/test-suite/trunk/cmake/caches/Release.cmake?rev=263456&r1=263455&r2=263456&view=diff
> ==============================================================================
> --- test-suite/trunk/cmake/caches/Release.cmake (original)
> +++ test-suite/trunk/cmake/caches/Release.cmake Mon Mar 14 13:12:36 2016
> @@ -1,4 +1,9 @@
> -set(CMAKE_C_FLAGS_RELEASE "-O3 -flto" CACHE STRING "")
> -set(CMAKE_CXX_FLAGS_RELEASE "-O3 -flto" CACHE STRING "")
> +# Aggressive settings to produce fast code.
> +set(OPTFLAGS "${OPTFLAGS} -O3 -march=native -fomit-frame-pointer -flto -DNDEBUG”)

I may be completely off as I actually don’t know when Release.cmake is used, but I am not sure I want the "-march=native” to be applied silently. The rationale is that we possibly cannot share our binary anymore between different CPUs.

Could you advice if this is actually a problem or am I missing something? :)

Cheers,
-Quentin

> +if(APPLE)
> +  set(OPTFLAGS "${OPTFLAGS} -mdynamic-no-pic")
> +endif()
> 
> -set(CMAKE_BUILD_TYPE "Release" CACHE STRING "")
> +set(CMAKE_C_FLAGS_RELEASE "${OPTFLAGS}" CACHE STRING "")
> +set(CMAKE_CXX_FLAGS_RELEASE "${OPTFLAGS}" CACHE STRING "")
> +set(CMAKE_BUILD_TYPE "Release")
> 
> Added: test-suite/trunk/cmake/caches/Release_Haswell.cmake
> URL: http://llvm.org/viewvc/llvm-project/test-suite/trunk/cmake/caches/Release_Haswell.cmake?rev=263456&view=auto
> ==============================================================================
> --- test-suite/trunk/cmake/caches/Release_Haswell.cmake (added)
> +++ test-suite/trunk/cmake/caches/Release_Haswell.cmake Mon Mar 14 13:12:36 2016
> @@ -0,0 +1,2 @@
> +set(OPTFLAGS "${OPTFLAGS} -march=haswell")
> +include(${CMAKE_CURRENT_LIST_DIR}/Release.cmake)
> 
> 
> _______________________________________________
> llvm-commits mailing list
> llvm-commits at lists.llvm.org
> http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits