[PATCH] D18094: [x86, AVX] replace masked load with full vector load when possible

Sanjay Patel via llvm-commits llvm-commits at lists.llvm.org
Mon Mar 14 09:22:16 PDT 2016


spatel added inline comments.

================
Comment at: lib/Target/X86/X86ISelLowering.cpp:27342
@@ -27341,6 +27341,3 @@
 
-/// Convert a masked load with a constant mask into a masked load and a select.
-/// This allows the select operation to use a faster kind of shuffle instruction
-/// (for example, vblendvps -> vblendps).
 static SDValue
 combineMaskedLoadConstantMask(MaskedLoadSDNode *ML, SelectionDAG &DAG,
----------------
ashutosh.nema wrote:
> Please retain and add comments here.
I moved the comment down to line 27365 because it wasn't function-level anymore. Please let me know if you have something else in mind. Thanks!


http://reviews.llvm.org/D18094





More information about the llvm-commits mailing list