[PATCH] D18133: allow branch weight metadata on select instructions (PR26636)

David Li via llvm-commits llvm-commits at lists.llvm.org
Sun Mar 13 10:45:18 PDT 2016


davidxl added a comment.

This definitetly the right thing to do.


================
Comment at: include/llvm/IR/IRBuilder.h:1579
@@ -1578,2 +1578,3 @@
 
   Value *CreateSelect(Value *C, Value *True, Value *False,
+                      const Twine &Name = "", MDNode *ProfWeights = nullptr) {
----------------
The cloneImpl  member method of the SelectInstr also needs to be updated to clone the metadata.


http://reviews.llvm.org/D18133





More information about the llvm-commits mailing list