[PATCH] D17936: [LICM] Don't silently ignore constant expressions in promoteLoopAccessesToScalars()

[Philip Reames via llvm-commits]

reames added a subscriber: reames.
reames added a comment.

I'm a bit confused by this patch.  Specifically, it looks like you're expecting ASIV to be @v, whereas the pointer being used is actually "i32* getelementptr inbounds ([4 x i32], [4 x i32]* @v" which should be handled perfectly fine by the loop promotion code.  I feel like you've probably misidentified the issue, but I can't tell from your test case what the actually issue is.

Can you explain a bit of your reasoning by which you arrived at this patch?

As a guess, are you possibly seeing @v and "i32* getelementptr inbounds ([4 x i32], [4 x i32]* @v" in a single must alias alias set?  If so, that would be a bug somewhere in the aliasing because those two are not must alias.


http://reviews.llvm.org/D17936