[PATCH] D17778: TypedError for recoverable error handling

Mehdi AMINI via llvm-commits llvm-commits at lists.llvm.org
Fri Mar 11 11:04:54 PST 2016


joker.eph added inline comments.

================
Comment at: include/llvm/Support/TypedError.h:359
@@ +358,3 @@
+/// checkAllErrors(std::move(E),
+///   handle<MyError>([](std::unique_ptr<MyError> M) {
+///     ...
----------------
lhames wrote:
> joker.eph wrote:
> > I like reading the `handle<MyError>(...)` but won't it be actually `handle<MyError>(...)`?
> I don't follow the question?
> 
> If you mean that this syntax is a bit verbose - I agree. I'll see if I can improve this.
The question was terrible (bad copy/paste). Let me phrase it again:

The doxygen says `handle<MyError>(...)`, but from what I can understand the function prototype below does not match and the code would be ` `handleTypedError<MyError>(...)`.
I like the former more :)


Repository:
  rL LLVM

http://reviews.llvm.org/D17778





More information about the llvm-commits mailing list