[lld] r263228 - Simplify now that local symbols can use getVA.

[Rafael Espíndola via llvm-commits]

On 11 March 2016 at 08:54, Simon Atanasyan <simon at atanasyan.com> wrote:
> On Fri, Mar 11, 2016 at 4:04 PM, Rafael Espindola via llvm-commits
> <llvm-commits at lists.llvm.org> wrote:
>> It is really odd that Mips differentiates symbols that are born local
>> and those that become local because of hidden visibility. I don't know
>> enough mips to known if this is a bug or not.
>
> Do you mean the fact that "true" local symbols got one kind of GOT
> entries with "page" address while symbols with hidden visibility got
> another kind of GOT entries with full address?
>
> If so it is not a bug, just an ABI requirement.

Sigh. Why is the ABI defined like that? If the symbol is hidden the
compiler knows it will be local in the DSO and should be able to use
the same code sequence as for local symbols.

Cheers,
Rafael