[lld] r263197 - [lto] The previous testcase was not useful enough.

Rui Ueyama via llvm-commits llvm-commits at lists.llvm.org
Thu Mar 10 21:48:11 PST 2016


On Thu, Mar 10, 2016 at 9:42 PM, Sean Silva via llvm-commits <
llvm-commits at lists.llvm.org> wrote:

> Author: silvas
> Date: Thu Mar 10 23:42:34 2016
> New Revision: 263197
>
> URL: http://llvm.org/viewvc/llvm-project?rev=263197&view=rev
> Log:
> [lto] The previous testcase was not useful enough.
>
> -shared was hiding the fact that the intrinsic wasn't being found.
>
> Modified:
>     lld/trunk/ELF/InputFiles.cpp
>     lld/trunk/test/ELF/lto/linkage.ll
>
> Modified: lld/trunk/ELF/InputFiles.cpp
> URL:
> http://llvm.org/viewvc/llvm-project/lld/trunk/ELF/InputFiles.cpp?rev=263197&r1=263196&r2=263197&view=diff
>
> ==============================================================================
> --- lld/trunk/ELF/InputFiles.cpp (original)
> +++ lld/trunk/ELF/InputFiles.cpp Thu Mar 10 23:42:34 2016
> @@ -454,6 +454,8 @@ void BitcodeFile::parse(DenseSet<StringR
>        ExtraKeeps.push_back(GV->getName().copy(Alloc));
>        continue;
>      }
> +    if (Flags & BasicSymbolRef::SF_FormatSpecific)
> +        continue;
>

Odd indentation.


>      uint8_t Visibility = getGvVisibility(GV);
>
>      SmallString<64> Name;
>
> Modified: lld/trunk/test/ELF/lto/linkage.ll
> URL:
> http://llvm.org/viewvc/llvm-project/lld/trunk/test/ELF/lto/linkage.ll?rev=263197&r1=263196&r2=263197&view=diff
>
> ==============================================================================
> --- lld/trunk/test/ELF/lto/linkage.ll (original)
> +++ lld/trunk/test/ELF/lto/linkage.ll Thu Mar 10 23:42:34 2016
> @@ -1,6 +1,7 @@
>  ; REQUIRES: x86
>  ; RUN: llvm-as %s -o %t1.o
>  ; RUN: ld.lld -m elf_x86_64 %t1.o %t1.o -o %t.so -shared
> +; RUN: llvm-nm %t.so | FileCheck %s
>
>  target datalayout = "e-m:e-i64:64-f80:128-n8:16:32:64-S128"
>  target triple = "x86_64-unknown-linux-gnu"
> @@ -16,3 +17,4 @@ define internal void @ctor() {
>
>  ; Should not try to merge a declaration into the combined module.
>  declare i32 @llvm.ctpop.i32(i32)
> +; CHECK-NOT: llvm.ctpop.i32
>
>
> _______________________________________________
> llvm-commits mailing list
> llvm-commits at lists.llvm.org
> http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20160310/1470b4ae/attachment.html>


More information about the llvm-commits mailing list