[PATCH] D18041: [ELF] use fatal() instead of llvm_unreachable when performing relaxations.

George Rimar via llvm-commits llvm-commits at lists.llvm.org
Thu Mar 10 11:39:58 PST 2016


grimar added a comment.

What is expected behavior if user gets llvm_unreachable in release for lld ?
If compiler will cut off the llvm_unreachable code, user probably will see nothing except crash.
We are using llvm_unreachable everywhere and just assuming it never gonna happen ?

(I am sorry if asking something obvious or already being answered, but that just very wierd for me).
fatal() at least will error out something. Why don't we use it for bugs and not only for errors ?
Doesn't error message is aways more userfriendly than crash ?


http://reviews.llvm.org/D18041





More information about the llvm-commits mailing list