[test-suite] r263146 - lit: Fix detection of non-zero exit codes in run-lines

Matthias Braun via llvm-commits llvm-commits at lists.llvm.org
Thu Mar 10 10:51:53 PST 2016


Author: matze
Date: Thu Mar 10 12:51:53 2016
New Revision: 263146

URL: http://llvm.org/viewvc/llvm-project?rev=263146&view=rev
Log:
lit: Fix detection of non-zero exit codes in run-lines

This went undetected before, because:
- RunSafely sets exitcodes to zero anyway and only puts the exitcode
  into the result file (I plan to change that for some benchmarks)
- The following "VERIFY:" step would usually catch failing executables.

Modified:
    test-suite/trunk/litsupport/test.py

Modified: test-suite/trunk/litsupport/test.py
URL: http://llvm.org/viewvc/llvm-project/test-suite/trunk/litsupport/test.py?rev=263146&r1=263145&r2=263146&view=diff
==============================================================================
--- test-suite/trunk/litsupport/test.py (original)
+++ test-suite/trunk/litsupport/test.py Thu Mar 10 12:51:53 2016
@@ -105,7 +105,7 @@ class TestSuiteTest(FileBasedTest):
             output += "\n" + "\n".join(runscript)
 
             out, err, exitCode, timeoutInfo = res
-            if exitCode == Test.FAIL:
+            if exitCode != 0:
                 # Only show command output in case of errors
                 output += "\n" + out
                 output += "\n" + err




More information about the llvm-commits mailing list