[PATCH] D17943: [Aarch64] Add pass LoopDataPrefetch for Cyclone

[Adam Nemet via llvm-commits]

anemet added a comment.

In http://reviews.llvm.org/D17943#371631, @t.p.northover wrote:

> Actually, if we do want cl::opt overrides, they should probably be within the pass itself. I'd be very annoyed as an x86 developer to discover that only AArch64 had the right to fiddle with these values during benchmarking.


I think we want them even long term.  (The fact they are currently implemented with static initializers is something that will hopefully go away.  I remember ChrisB working on this some time ago.)  But anyhow your comment is obviously valid.

I can move them to the pass but I guess since they are TTIs they could in theory be used by other passes as well.  So logically they would belong more to TTI base class definition...

What do you think?  I can start a  follow-on llvm-dev thread to discuss it.

Thanks for the reviews.

Adam


http://reviews.llvm.org/D17943