[PATCH] D18041: [ELF] use fatal() instead of llvm_unreachable when performing relaxations.

Rafael EspĂ­ndola via llvm-commits llvm-commits at lists.llvm.org
Thu Mar 10 09:47:32 PST 2016


On 10 March 2016 at 12:46, George Rimar <grimar at accesssoftek.com> wrote:
>>How does using assert help? llvm_unreachable(msg) is basically assert(0 && msg);
>
> Nohow, sorry, for some reason I thought it has form with Twine& argument,
> was confused it with error().
>
> Then possible solution looks a bit ugly for me:
> llvm_unreachable((Twine("Unknown TLS optimization: ") + Twine(Type)).str().c_str());

Is that optimized away in a Release build?

Cheers,
Rafael


More information about the llvm-commits mailing list