[PATCH] D18048: [AArch64] Enable load clustering of unscaled loads in the MI Scheduler.

Chad Rosier via llvm-commits llvm-commits at lists.llvm.org
Thu Mar 10 09:40:57 PST 2016


mcrosier marked an inline comment as done.

================
Comment at: lib/Target/AArch64/AArch64InstrInfo.cpp:1501
@@ +1500,3 @@
+    // loads/stores.
+    if (Offset1 % OffsetStride)
+      return false;
----------------
gberry wrote:
> Don't you need to check this for Offset2 as well?
> 
> Also, I'm not sure what the style guide says, but should this be?
>   if (Offset1 % OffsetStride != 0)
Yes, I believe you're correct.  We do need to check Offset2 as well.

I'll make the style change as well.


http://reviews.llvm.org/D18048





More information about the llvm-commits mailing list