[PATCH] D16057: [SROA] Fix for PR25873: Pre-splitting should always preserve the partition structure.

[Andrea Di Biagio via llvm-commits]

andreadb added a comment.

In http://reviews.llvm.org/D16057#371909, @chandlerc wrote:

> I'm so, so sorry about this.
>
> Not only for taking so long to get to it, but finally, I understand why I kept being confused when I looked at this patch.
>
> I *COMPLETELY* messed up when I said that this was the correct fix. =[ The root cause of the bug was actually failing to bail out of pre-splitting earlier. There is a simple explanation, and it all stemmed from a previous patch of mine. I just missed a case.
>
> =[ =[ =[ =[ =[
>
> I feel really terrible about how much work you've done because I misunderstood the root cause. So sorry about that.
>
> Anyways, the root cause is also *super easy* to fix. I've gone ahead and landed the fix in r263121 using the excellent test case here.
>
> Again, so sorry. =[ =[ =[


Hey Chandler,

Don't worry! I knew that you have been very busy lately.
For what is worth, overall I don't feel like it was a waste time; at least now I know a bit more about SROA ;-). 
Also, we weren't blocked by this issue as internally we had a conservative fix in place.

Anyway, I am very happy that the bug is fixed now.

Thanks,
Andrea


http://reviews.llvm.org/D16057