[PATCH] D18004: [ELF] - refactor of SymbolBody::compare()

George Rimar via llvm-commits llvm-commits at lists.llvm.org
Thu Mar 10 02:04:50 PST 2016


grimar added inline comments.

================
Comment at: ELF/Symbols.cpp:159
@@ -161,2 +158,3 @@
+  return isCommon() ? -1 : 1;
 }
 
----------------
Actually I don't like that part of code. There is to much attention to commons. But I dont have ideas how to improve that. Also in my opinion it is still better than was before.


http://reviews.llvm.org/D18004





More information about the llvm-commits mailing list