[PATCH] D17928: [sanitizer_common tests] Make Darwin a Posix system and bring the stable-runtime definition from ASan tests.

Filipe Cabecinhas via llvm-commits llvm-commits at lists.llvm.org
Thu Mar 10 01:33:14 PST 2016


Fair enough. I'll just factor out the definition and put the ARM
variants in the !stable-runtime camp.

Will upload in a bit.

Thank you,

  Filipe

On Wed, Mar 9, 2016 at 11:47 PM, Alexey Samsonov <vonosmas at gmail.com> wrote:
> samsonov added inline comments.
>
> ================
> Comment at: test/sanitizer_common/lit.common.cfg:13
> @@ +12,3 @@
> +  # Get the same definition from asan's lit.cfg
> +  if config.target_arch != 'arm' and config.target_arch != 'armhf' and config.target_arch != 'aarch64':
> +    config.available_features.add('stable-runtime')
> ----------------
> I mean, can you factor out this definition outside of "config.tool_name" conditions? It won't do harm for tsan/msan, as we don't build them for arm and armhf anyway, and I'm not sure we have a decent support for LSan as well.
>
>
> http://reviews.llvm.org/D17928
>
>
>


More information about the llvm-commits mailing list