[PATCH] D17943: [Aarch64] Add pass LoopDataPrefetch for Cyclone

Tim Northover via llvm-commits llvm-commits at lists.llvm.org
Wed Mar 9 21:47:45 PST 2016


t.p.northover added a comment.

Yep, I think it looks reasonable for now.

On the longer-term, what are the plans over the cl::opts? They're static initializers which really aren't encouraged, and Cyclone is what it is. If we're still using them for perf-testing on Cyclone (or its descendents), fine.

But otherwise I think they should either be removed or made into tweakables that everyone can experiment with (i.e. the cl::opt overrides everything, Cyclone has a hard-coded 280 if it's not specified).

Cheers.

Tim.


http://reviews.llvm.org/D17943





More information about the llvm-commits mailing list