[PATCH] D18002: Add an LLVM_BUILTIN_DEBUGTRAP macro.

Eric Christopher via llvm-commits llvm-commits at lists.llvm.org
Wed Mar 9 21:28:36 PST 2016


No disagreements. Just commenting. :)

On Wed, Mar 9, 2016, 4:05 PM Mark Lacey <mark.lacey at apple.com> wrote:

> rudkx added a comment.
>
> Thanks for taking a look!
>
> I agree that it's a bit odd that both do the same for MSVC, but it seems
> like the right fix for that issue is to change LLVM_BUILTIN_TRAP to fail
> differently than using __debugbreak (either RaiseException which appears to
> be deliberately avoided, or inline asm with ud2 perhaps?).
>
>
> http://reviews.llvm.org/D18002
>
>
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20160310/eb23b8d7/attachment.html>


More information about the llvm-commits mailing list