[PATCH] D18010: AMDGPU: R600 code splitting cleanup

[David Blaikie via llvm-commits]

On Wed, Mar 9, 2016 at 12:29 PM, Matt Arsenault via llvm-commits <
llvm-commits at lists.llvm.org> wrote:

> arsenm created this revision.
> arsenm added a reviewer: tstellarAMD.
> arsenm added a subscriber: llvm-commits.
> Herald added subscribers: arsenm, MatzeB.
>
> Move a few functions only used by R600 to R600 specific code,
> fix header macros to stop using R600, mark classes as final.
>

What's the reason for marking the classes final? We don't usually go out of
our way to do that, except for -Wnon-virtual-dtor silencing (in my
experience/practice) - so perhaps it's that case? (just not clear to me
from the commit/code (without going & looking at the hierarchies, etc)


>
> http://reviews.llvm.org/D18010
>
> Files:
>   lib/Target/AMDGPU/AMDGPU.h
>   lib/Target/AMDGPU/AMDGPUAsmPrinter.h
>   lib/Target/AMDGPU/AMDGPUISelLowering.cpp
>   lib/Target/AMDGPU/AMDGPUISelLowering.h
>   lib/Target/AMDGPU/AMDGPUInstrInfo.h
>   lib/Target/AMDGPU/AMDGPUIntrinsicInfo.h
>   lib/Target/AMDGPU/AMDGPUMCInstLower.h
>   lib/Target/AMDGPU/AMDGPUMachineFunction.h
>   lib/Target/AMDGPU/AMDGPURegisterInfo.h
>   lib/Target/AMDGPU/AMDGPUTargetMachine.cpp
>   lib/Target/AMDGPU/AMDGPUTargetMachine.h
>   lib/Target/AMDGPU/AMDGPUTargetTransformInfo.h
>   lib/Target/AMDGPU/InstPrinter/AMDGPUInstPrinter.h
>   lib/Target/AMDGPU/MCTargetDesc/AMDGPUELFStreamer.h
>   lib/Target/AMDGPU/MCTargetDesc/AMDGPUFixupKinds.h
>   lib/Target/AMDGPU/MCTargetDesc/AMDGPUMCAsmInfo.h
>   lib/Target/AMDGPU/MCTargetDesc/AMDGPUMCCodeEmitter.h
>   lib/Target/AMDGPU/MCTargetDesc/AMDGPUMCTargetDesc.h
>   lib/Target/AMDGPU/MCTargetDesc/AMDGPUTargetStreamer.h
>   lib/Target/AMDGPU/R600Defines.h
>   lib/Target/AMDGPU/R600ISelLowering.cpp
>   lib/Target/AMDGPU/R600ISelLowering.h
>   lib/Target/AMDGPU/R600InstrInfo.h
>   lib/Target/AMDGPU/R600MachineFunctionInfo.h
>   lib/Target/AMDGPU/R600MachineScheduler.h
>   lib/Target/AMDGPU/R600RegisterInfo.h
>   lib/Target/AMDGPU/SIDefines.h
>   lib/Target/AMDGPU/SIISelLowering.h
>   lib/Target/AMDGPU/SIInstrInfo.h
>   lib/Target/AMDGPU/SIMachineFunctionInfo.h
>   lib/Target/AMDGPU/SIMachineScheduler.h
>   lib/Target/AMDGPU/SIRegisterInfo.h
>
>
> _______________________________________________
> llvm-commits mailing list
> llvm-commits at lists.llvm.org
> http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20160309/73239da3/attachment.html>