[PATCH] D17985: [Compiler-rt] Fix ioctl codes for MIPS in sanitizer_ioctl_test

Alexey Samsonov via llvm-commits llvm-commits at lists.llvm.org
Wed Mar 9 15:48:55 PST 2016


samsonov added inline comments.

================
Comment at: lib/sanitizer_common/tests/sanitizer_ioctl_test.cc:81
@@ -80,1 +80,3 @@
   ioctl_desc desc;
+#if SANITIZER_MIPS
+  bool res = ioctl_decode(0x4004ae98U, &desc);
----------------
Try to avoid #if where possible. E.g. can you make it
  unsigned int desc_value = SANITIZER_MIPS ? 0x4004ae98U : 0x8004ae98U;
  bool res = ioctl_decode(write_desc, &desc);
?


Repository:
  rL LLVM

http://reviews.llvm.org/D17985





More information about the llvm-commits mailing list