[PATCH] D15912: [BasicAA/MDA] Sink aliasing rules for malloc and calloc into BasicAA

[Daniel Berlin via llvm-commits]

Sorry. I realized exactly what you said and thought i removed the comment,
but apparently not :)


On Wed, Mar 9, 2016 at 2:14 PM, Philip Reames <listmail at philipreames.com>
wrote:

> reames added inline comments.
>
> ================
> Comment at: lib/Analysis/BasicAliasAnalysis.cpp:744
> @@ -731,1 +743,3 @@
> +  }
> +
>    // While the assume intrinsic is marked as arbitrarily writing so that
> ----------------
> dberlin wrote:
> > What happens to alloca here?
> Nothing, it's not a call site.
>
> I think what you're getting at is whether we need alloca handling in MDA.
> The flow there is unchanged.  The mustalias (early def) case is exactly the
> same and Alloca's don't modify memory so we explicitly skip over them.  The
> previous code would have either early continued or hit the NoModRef case
> inside getModRefInfo(Instruction*, MemLoc); in either case, we skip the
> alloca.
>
> Actually, that points out the isa<AllocaInst> check I added in MDA is
> completely redundant.  I'll; remove that.
>
>
> http://reviews.llvm.org/D15912
>
>
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20160309/935604fd/attachment.html>