[PATCH] D17946: Add a flag to the LLVMContext to disable name for Value other than GlobalValue

[Mehdi AMINI via llvm-commits]

joker.eph marked 3 inline comments as done.

================
Comment at: lib/IR/LLVMContextImpl.h:1037-1039
@@ -1036,1 +1036,5 @@
 
+  /// Flag to indicate if Value (other than GlobalValue) retains their name or
+  /// not.
+  bool PreserveNames = true;
+
----------------
chandlerc wrote:
> I would make this consistent with the interface (DiscardValueNames).
Ohhhh it is event worse than a just name bikeshedding, there is unintended behavior change here! The default would have been to Discard names...
(I didn't notice in the tests because I only ran opt/llc tests with this last change and these will always explicitly set it to false based on the cl::opt, it would have impacted other llvm clients)


http://reviews.llvm.org/D17946