[PATCH] D17884: Disallow duplication of imported entities

Amjad Aboud via llvm-commits llvm-commits at lists.llvm.org
Wed Mar 9 01:19:54 PST 2016

aaboud added a comment.

I just figure out why this approach will not work.
The idea here was to get rid of AllImportedModules list and use the DIImportedEntitys list from the LLVMContextImpl class, assuming that they contain the same info, which is wrong.
AllImportedModules list is per DICompileUnit, while DIImportedEntitys contains all the imported entities from all Compile units.

We cannot get rid of AllImportedModules, thus I will revert this patch to Diff 2.


More information about the llvm-commits mailing list