[PATCH] D17549: [PATCH] More UTF string conversion wrappers

Aaron Ballman via llvm-commits llvm-commits at lists.llvm.org
Tue Mar 8 15:30:25 PST 2016


aaron.ballman added inline comments.

================
Comment at: llvm/trunk/lib/Support/ConvertUTFWrapper.cpp:190
@@ +189,3 @@
+  const UTF8 *ErrorPtr;
+  if (!ConvertUTF8toWide(sizeof(wchar_t), Source, ResultPtr, ErrorPtr))
+  {
----------------
cameron314 wrote:
> aaron.ballman wrote:
> > You should run clang-format over this as well, the formatting isn't correct (here and elsewhere in the file).
> Will do. I was hoping to avoid this since clang-format changes a lot of code that was already present as well. I'll extract just the parts that apply to my patch, I suppose.
You can run clang-format over the patch file directly, too. http://clang.llvm.org/docs/ClangFormat.html#script-for-patch-reformatting


http://reviews.llvm.org/D17549





More information about the llvm-commits mailing list