[PATCH] D17971: [lto] Don't add variables with private linkage to the symbol table.

[Rafael Ávila de Espíndola via llvm-commits]

rafael accepted this revision.
rafael added a comment.
This revision is now accepted and ready to land.

LGTM with nits.


================
Comment at: ELF/InputFiles.cpp:447
@@ -446,1 +446,3 @@
           continue;
+      if (GV->getLinkage() == GlobalValue::PrivateLinkage)
+        continue;
----------------
Please move getFlags earlier and use

if (!(Fags & object::BasicSymbolRef::SF_Global))
  continue;


================
Comment at: test/ELF/lto/linkage.ll:4
@@ +3,3 @@
+; RUN: llvm-as %p/Inputs/linkage.ll -o %t2.o
+; RUN: ld.lld -m elf_x86_64 %t1.o %t2.o -o %t.so -shared
+
----------------
Can you just pass %t1.o twice?


http://reviews.llvm.org/D17971