[lld] r262941 - Revert "ELF: Add /lib and /usr/lib as default search paths."

[Rafael Espindola via llvm-commits]

Author: rafael
Date: Tue Mar  8 11:13:12 2016
New Revision: 262941

URL: http://llvm.org/viewvc/llvm-project?rev=262941&view=rev
Log:
Revert "ELF: Add /lib and /usr/lib as default search paths."

It was causing errors like

/lib/libc.so.6 is incompatible with elf_x86_64

when linking on Fedora.

Every system has different default paths. It seems better to just trust
the driver to pass the correct -L options.

This reverts commit 262910.

Removed:
    lld/trunk/test/ELF/Inputs/nostdlib.s
    lld/trunk/test/ELF/nostdlib.s
Modified:
    lld/trunk/ELF/Config.h
    lld/trunk/ELF/Driver.cpp
    lld/trunk/ELF/LinkerScript.cpp
    lld/trunk/ELF/Options.td

Modified: lld/trunk/ELF/Config.h
URL: http://llvm.org/viewvc/llvm-project/lld/trunk/ELF/Config.h?rev=262941&r1=262940&r2=262941&view=diff
==============================================================================
--- lld/trunk/ELF/Config.h (original)
+++ lld/trunk/ELF/Config.h Tue Mar  8 11:13:12 2016
@@ -67,7 +67,6 @@ struct Configuration {
   bool Mips64EL = false;
   bool NoUndefined;
   bool NoinhibitExec;
-  bool Nostdlib;
   bool PrintGcSections;
   bool Relocatable;
   bool Shared;

Modified: lld/trunk/ELF/Driver.cpp
URL: http://llvm.org/viewvc/llvm-project/lld/trunk/ELF/Driver.cpp?rev=262941&r1=262940&r2=262941&view=diff
==============================================================================
--- lld/trunk/ELF/Driver.cpp (original)
+++ lld/trunk/ELF/Driver.cpp Tue Mar  8 11:13:12 2016
@@ -207,6 +207,9 @@ void LinkerDriver::main(ArrayRef<const c
 
 // Initializes Config members by the command line options.
 void LinkerDriver::readConfigs(opt::InputArgList &Args) {
+  for (auto *Arg : Args.filtered(OPT_L))
+    Config->SearchPaths.push_back(Arg->getValue());
+
   std::vector<StringRef> RPaths;
   for (auto *Arg : Args.filtered(OPT_rpath))
     RPaths.push_back(Arg->getValue());
@@ -234,7 +237,6 @@ void LinkerDriver::readConfigs(opt::Inpu
   Config->ICF = Args.hasArg(OPT_icf);
   Config->NoUndefined = Args.hasArg(OPT_no_undefined);
   Config->NoinhibitExec = Args.hasArg(OPT_noinhibit_exec);
-  Config->Nostdlib = Args.hasArg(OPT_nostdlib);
   Config->PrintGcSections = Args.hasArg(OPT_print_gc_sections);
   Config->Relocatable = Args.hasArg(OPT_relocatable);
   Config->Shared = Args.hasArg(OPT_shared);
@@ -277,14 +279,6 @@ void LinkerDriver::readConfigs(opt::Inpu
 
   for (auto *Arg : Args.filtered(OPT_undefined))
     Config->Undefined.push_back(Arg->getValue());
-
-  if (!Config->Nostdlib) {
-    Config->SearchPaths.push_back("=/lib");
-    Config->SearchPaths.push_back("=/usr/lib");
-  }
-
-  for (auto *Arg : Args.filtered(OPT_L))
-    Config->SearchPaths.push_back(Arg->getValue());
 }
 
 void LinkerDriver::createFiles(opt::InputArgList &Args) {

Modified: lld/trunk/ELF/LinkerScript.cpp
URL: http://llvm.org/viewvc/llvm-project/lld/trunk/ELF/LinkerScript.cpp?rev=262941&r1=262940&r2=262941&view=diff
==============================================================================
--- lld/trunk/ELF/LinkerScript.cpp (original)
+++ lld/trunk/ELF/LinkerScript.cpp Tue Mar  8 11:13:12 2016
@@ -396,9 +396,7 @@ void ScriptParser::readOutputFormat() {
 
 void ScriptParser::readSearchDir() {
   expect("(");
-  StringRef Path = next();
-  if (!Config->Nostdlib)
-    Config->SearchPaths.push_back(Path);
+  Config->SearchPaths.push_back(next());
   expect(")");
 }
 

Modified: lld/trunk/ELF/Options.td
URL: http://llvm.org/viewvc/llvm-project/lld/trunk/ELF/Options.td?rev=262941&r1=262940&r2=262941&view=diff
==============================================================================
--- lld/trunk/ELF/Options.td (original)
+++ lld/trunk/ELF/Options.td Tue Mar  8 11:13:12 2016
@@ -91,9 +91,6 @@ def noinhibit_exec : Flag<["--"], "noinh
 def no_undefined : Flag<["--"], "no-undefined">,
   HelpText<"Report unresolved symbols even if the linker is creating a shared library">;
 
-def nostdlib: Flag<["-", "--"], "nostdlib">,
-  HelpText<"Only search directories specified on the command line">;
-
 def o : JoinedOrSeparate<["-"], "o">, MetaVarName<"<path>">,
   HelpText<"Path to file to write output">;
 

Removed: lld/trunk/test/ELF/Inputs/nostdlib.s
URL: http://llvm.org/viewvc/llvm-project/lld/trunk/test/ELF/Inputs/nostdlib.s?rev=262940&view=auto
==============================================================================
--- lld/trunk/test/ELF/Inputs/nostdlib.s (original)
+++ lld/trunk/test/ELF/Inputs/nostdlib.s (removed)
@@ -1,3 +0,0 @@
-.globl foo
-foo:
-  ret

Removed: lld/trunk/test/ELF/nostdlib.s
URL: http://llvm.org/viewvc/llvm-project/lld/trunk/test/ELF/nostdlib.s?rev=262940&view=auto
==============================================================================
--- lld/trunk/test/ELF/nostdlib.s (original)
+++ lld/trunk/test/ELF/nostdlib.s (removed)
@@ -1,16 +0,0 @@
-# REQUIRES: x86
-
-# RUN: mkdir -p %t.dir/lib
-# RUN: mkdir -p %t.dir/usr/lib
-# RUN: llvm-mc -filetype=obj -triple=x86_64-unknown-linux %s -o %t1.o
-# RUN: llvm-mc -filetype=obj -triple=x86_64-unknown-linux %p/Inputs/nostdlib.s -o %t2.o
-# RUN: ld.lld -shared -o %t.dir/lib/libfoo.so %t2.o
-# RUN: ld.lld -shared -o %t.dir/usr/lib/libbar.so %t2.o
-# RUN: ld.lld --sysroot=%t.dir -o %t %t1.o -lfoo
-# RUN: ld.lld --sysroot=%t.dir -o %t %t1.o -lbar
-# RUN: not ld.lld --sysroot=%t.dir -nostdlib -o %t %t1.o -lfoo
-# RUN: not ld.lld --sysroot=%t.dir -nostdlib -o %t %t1.o -lbar
-
-.globl _start
-_start:
-  ret