[PATCH] D14840: [X86] Detect SAD patterns and emit psadbw instructions on X86.

Chandler Carruth via llvm-commits llvm-commits at lists.llvm.org
Tue Mar 8 04:54:33 PST 2016


chandlerc added a subscriber: chandlerc.
chandlerc added a comment.

Simon and Ahmed seem to have a good handle on this, just wanted to say...

In http://reviews.llvm.org/D14840#369592, @RKSimon wrote:

> The checks on the tests are quite poor - I understand that update_llc_test_checks.py output might be too much but please see if you can expand the checks to give a better idea of context.


I would strongly encourage folks to use update_llc_test_checks.py. If it's not working here, we should make a version that does work. The resulting test accuracy is just such a huge improvement.


http://reviews.llvm.org/D14840





More information about the llvm-commits mailing list