[llvm] r262907 - Fix evaluation order. Spotted by Alexander Riccio!

Peter Collingbourne via llvm-commits llvm-commits at lists.llvm.org
Mon Mar 7 19:50:37 PST 2016


Author: pcc
Date: Mon Mar  7 21:50:36 2016
New Revision: 262907

URL: http://llvm.org/viewvc/llvm-project?rev=262907&view=rev
Log:
Fix evaluation order. Spotted by Alexander Riccio!

Modified:
    llvm/trunk/lib/Transforms/IPO/WholeProgramDevirt.cpp

Modified: llvm/trunk/lib/Transforms/IPO/WholeProgramDevirt.cpp
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/Transforms/IPO/WholeProgramDevirt.cpp?rev=262907&r1=262906&r2=262907&view=diff
==============================================================================
--- llvm/trunk/lib/Transforms/IPO/WholeProgramDevirt.cpp (original)
+++ llvm/trunk/lib/Transforms/IPO/WholeProgramDevirt.cpp Mon Mar  7 21:50:36 2016
@@ -459,7 +459,7 @@ bool DevirtModule::tryUniqueRetValOpt(
   auto tryUniqueRetValOptFor = [&](bool IsOne) {
     const BitSetInfo *UniqueBitSet = 0;
     for (const VirtualCallTarget &Target : TargetsForSlot) {
-      if (Target.RetVal == IsOne ? 1 : 0) {
+      if (Target.RetVal == (IsOne ? 1 : 0)) {
         if (UniqueBitSet)
           return false;
         UniqueBitSet = Target.BS;




More information about the llvm-commits mailing list