[PATCH] D17900: [gold] Fix common symbols handling

[Rafael Espíndola via llvm-commits]

On Mar 7, 2016 1:43 PM, "Evgenii Stepanov" <eugenis at google.com> wrote:
>
> Yes. It only matters with tot gold, when the plugin has the ability to
drop inputs. I guess I'll have to figure out a way to check for the linker
version in tests.

If you want, for now just create a new test with

REQUIRES: NEWGOLD

It will show up as unsupported everywhere, but should let me review it
locally.

>
> On Mar 7, 2016 6:58 AM, "Rafael Espíndola" <rafael.espindola at gmail.com>
wrote:
>>
>> The test passes with the patch reverted.
>>
>>
>> On 4 March 2016 at 19:32, Evgeniy Stepanov <eugenis at google.com> wrote:
>> > eugenis created this revision.
>> > eugenis added a reviewer: rafael.
>> > eugenis added a subscriber: llvm-commits.
>> > eugenis set the repository for this revision to rL LLVM.
>> >
>> > LLVM Gold plugin decides which instance of a common symbol it wants
>> > based on the symbol size in claim_file_hook. If the file that
>> > contains the chosen instance is later dropped from the link, we end
>> > up with an undefined reference.
>> >
>> > This change delays this decision until the set of the included files
>> > is known.
>> >
>> > Repository:
>> >   rL LLVM
>> >
>> > http://reviews.llvm.org/D17900
>> >
>> > Files:
>> >   test/tools/gold/X86/Inputs/common.ll
>> >   test/tools/gold/X86/Inputs/common2.ll
>> >   test/tools/gold/X86/common.ll
>> >   tools/gold/gold-plugin.cpp
>> >
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20160307/c1e39798/attachment.html>