[PATCH] D17066: libLTO: add a ThinLTOCodeGenerator on the model of LTOCodeGenerator.

[Mehdi AMINI via llvm-commits]

joker.eph added a comment.

Thanks Gao!


================
Comment at: include/llvm-c/lto.h:699
@@ +698,3 @@
+ * Test if a module has support for ThinLTO linking.
+ */
+extern bool lto_module_is_thinlto(lto_module_t mod);
----------------
ygao wrote:
> This, and the two functions that ensue, may also need to say LTO_API_VERSION=18?
> I think it is more natural to say "a list of global symbols" than "a list of all global symbols", but English is not my first language.
Good catch. Will fix (both).

================
Comment at: lib/LTO/ThinLTOCodeGenerator.cpp:44
@@ +43,3 @@
+#include <unordered_map>
+#include <unordered_set>
+
----------------
ygao wrote:
> Do you need unordered_set here? I did not see unordered_set being used in this file.
It used in a more elaborate version of this code that I have locally, but not needed here. Will remove.


http://reviews.llvm.org/D17066