[PATCH] D7378: llvm-readobj: implement MachODumper::printNeededLibraries

Chilledheart via llvm-commits llvm-commits at lists.llvm.org
Mon Mar 7 10:35:14 PST 2016


chilledheart added a comment.

Ping?


================
Comment at: tools/llvm-readobj/MachODumper.cpp:617
@@ +616,3 @@
+
+  std::stable_sort(Libs.begin(), Libs.end());
+
----------------
kledzik wrote:
> Why sort?  The order is important in mach-o.  The symbol table entries for undefined symbols contain a one byte "ordinal" which is the index into this ordered list.
removed


http://reviews.llvm.org/D7378





More information about the llvm-commits mailing list