[PATCH] D17040: [mips] Expansion of BEQL and BNEL with immediate operands

Srdjan Obucina via llvm-commits llvm-commits at lists.llvm.org
Mon Mar 7 07:20:50 PST 2016


obucina added a comment.

Can You please be more precise what exactly You are expecting to be changed?

branch-pseudo.s is a set of tests for branch instructions with register operands. I guess You think we need tests for global labels?

branch-pseudo-bad.s also covers branch instructions with register operands. I guess You want to test for AT reg availability here?

set-nomacro.s covers branch instructions, but not branch likely instructions? Do You want to add these two instructions here? For the sake of completeness, what about other branch likely instructions?

Just be more precise, please...


http://reviews.llvm.org/D17040





More information about the llvm-commits mailing list