[PATCH] D17767: [ms-inline-asm][AVX512] Add ability to use k registers in MS inline asm + fix bag with curly braces

Marina Yatsina via llvm-commits llvm-commits at lists.llvm.org
Mon Mar 7 07:02:25 PST 2016


myatsina marked an inline comment as done.

================
Comment at: lib/Target/X86/AsmParser/X86AsmParser.cpp:2307
@@ -2306,2 +2306,3 @@
 
+  bool CurlyAsEndOfStatement = false;
   // This does the actual operand parsing.  Don't parse any more if we have a
----------------
delena wrote:
> auto isCurlyBrace = []() {
>   return getLexer().is(AsmToken::LCurly) || getLexer().is(AsmToken::RCurly);
> }
We do need the logic that checks that we're dealing with intel syntax and parsing inline asm (otherwise we're parsing asm code of an s file). 
I prefer this logic as a variable and not a function.



Repository:
  rL LLVM

http://reviews.llvm.org/D17767





More information about the llvm-commits mailing list