[PATCH] D17900: [gold] Fix common symbols handling

Rafael EspĂ­ndola via llvm-commits llvm-commits at lists.llvm.org
Mon Mar 7 06:58:31 PST 2016

The test passes with the patch reverted.

On 4 March 2016 at 19:32, Evgeniy Stepanov <eugenis at google.com> wrote:
> eugenis created this revision.
> eugenis added a reviewer: rafael.
> eugenis added a subscriber: llvm-commits.
> eugenis set the repository for this revision to rL LLVM.
> LLVM Gold plugin decides which instance of a common symbol it wants
> based on the symbol size in claim_file_hook. If the file that
> contains the chosen instance is later dropped from the link, we end
> up with an undefined reference.
> This change delays this decision until the set of the included files
> is known.
> Repository:
>   rL LLVM
> http://reviews.llvm.org/D17900
> Files:
>   test/tools/gold/X86/Inputs/common.ll
>   test/tools/gold/X86/Inputs/common2.ll
>   test/tools/gold/X86/common.ll
>   tools/gold/gold-plugin.cpp

More information about the llvm-commits mailing list