[PATCH] D16381: Infrastructure to allow use of PGO in inliner

Chandler Carruth via llvm-commits llvm-commits at lists.llvm.org
Mon Mar 7 01:40:58 PST 2016


chandlerc added a comment.

In http://reviews.llvm.org/D16381#367348, @davidxl wrote:

> LGTM.
>
> This looks really great, so let's move on with this long waited missing feature.


David, this is not an area of LLVM you have done substantial work on, and this is a very significant feature.

I'm sorry that I have not had time to review this yet, but the correct response is not for you to make a patch as LGTM. Please revert this and let's actually get it reviewed before it goes into the project.


Repository:
  rL LLVM

http://reviews.llvm.org/D16381





More information about the llvm-commits mailing list