[PATCH] D17912: [ELF] - Remove unused member from SymbolTable

George Rimar via llvm-commits llvm-commits at lists.llvm.org
Sun Mar 6 00:26:18 PST 2016


grimar created this revision.
grimar added reviewers: ruiu, rafael.
grimar added subscribers: llvm-commits, grimar.

We dont use the ArchiveFiles member, just filling it
with files for no reason.
I think we can remove it.

http://reviews.llvm.org/D17912

Files:
  ELF/SymbolTable.cpp
  ELF/SymbolTable.h

Index: ELF/SymbolTable.h
===================================================================
--- ELF/SymbolTable.h
+++ ELF/SymbolTable.h
@@ -94,7 +94,6 @@
   llvm::DenseSet<StringRef> ComdatGroups;
 
   // The symbol table owns all file objects.
-  std::vector<std::unique_ptr<ArchiveFile>> ArchiveFiles;
   std::vector<std::unique_ptr<ObjectFile<ELFT>>> ObjectFiles;
   std::vector<std::unique_ptr<SharedFile<ELFT>>> SharedFiles;
   std::vector<std::unique_ptr<BitcodeFile>> BitcodeFiles;
Index: ELF/SymbolTable.cpp
===================================================================
--- ELF/SymbolTable.cpp
+++ ELF/SymbolTable.cpp
@@ -58,7 +58,6 @@
 
   // .a file
   if (auto *F = dyn_cast<ArchiveFile>(FileP)) {
-    ArchiveFiles.emplace_back(cast<ArchiveFile>(File.release()));
     F->parse();
     for (Lazy &Sym : F->getLazySymbols())
       addLazy(&Sym);


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D17912.49895.patch
Type: text/x-patch
Size: 865 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20160306/7f406eda/attachment.bin>


More information about the llvm-commits mailing list