[PATCH] D16783: [LICM] Store promotion when memory is thread local

[Philip Reames via llvm-commits]

reames added inline comments.

================
Comment at: lib/Transforms/Scalar/LICM.cpp:1012
@@ +1011,3 @@
+        if (!GuaranteedToExecute && !CanSpeculateLoad) {
+          CanSpeculateLoad =
+            isDereferenceableAndAlignedPointer(Store->getPointerOperand(),
----------------
sanjoy wrote:
> So part of the confusion here for me is that `CanSpeculateLoad` looks like it is really tracking something else.  Does it make sense to rename it to `CanPromoteAliasSet`?
I really not getting the confusion here.  Per the comment on the variable you're asking me to rename, it really is answering only the speculation legality question.  In particular, that by itself is not enough to establish promotion is legal.  That's the whole point.


http://reviews.llvm.org/D16783