[PATCH] D16875: MemorySSA Optimizations: Patch 1 of N

David Li via llvm-commits llvm-commits at lists.llvm.org
Fri Mar 4 11:29:59 PST 2016


davidxl added inline comments.

================
Comment at: lib/Transforms/Utils/MemorySSA.cpp:864
@@ +863,3 @@
+/// (Where potentially clobbering ops are memory barriers, aliased stores, etc.)
+static bool canLoadsBeReordered(const LoadInst *Use, const LoadInst *MayDef) {
+  // Volatile operations can never be reordered with other volatile operations,
----------------
The overall structure of the patch looks good -- however this function still needs more scrutiny -- please ping Phillip or Hal for more comments.


http://reviews.llvm.org/D16875





More information about the llvm-commits mailing list