[PATCH] D17872: [NVPTX] Add a truncate DAG node to some calls.

Justin Lebar via llvm-commits llvm-commits at lists.llvm.org
Fri Mar 4 09:52:20 PST 2016


jlebar added inline comments.

================
Comment at: lib/Target/NVPTX/NVPTXISelLowering.cpp:1641
@@ -1637,3 +1640,3 @@
           //   trunc i16 to i1/i8
           LoadRetVTs.push_back(MVT::i16);
         } else
----------------
jingyue wrote:
> Why shouldn't we set `needTruncate` here too? 
Interesting...  I think this comment is wrong?  If returning i1 or i8 (or i16), we should hit the first branch.  This branch should be for *non-int* types of size less than 16?  But then, I'm not sure what that is, so I'm not sure when we ever run this code.


http://reviews.llvm.org/D17872





More information about the llvm-commits mailing list