[PATCH] D17760: [mips] Fix an issue with long double when function roundl is defined

Zlatko Buljan via llvm-commits llvm-commits at lists.llvm.org
Fri Mar 4 01:54:49 PST 2016


zbuljan updated this revision to Diff 49803.
zbuljan added a comment.

Updated .ll with tests for N32 and soft-float.
Removed unnecessary IR code.
.ll file moved to test/CodeGen/Mips/cconv/ folder.


http://reviews.llvm.org/D17760

Files:
  lib/Target/Mips/MipsCCState.cpp
  test/CodeGen/Mips/cconv/roundl-call.ll

Index: test/CodeGen/Mips/cconv/roundl-call.ll
===================================================================
--- /dev/null
+++ test/CodeGen/Mips/cconv/roundl-call.ll
@@ -0,0 +1,44 @@
+; RUN: llc -march=mips64 -mcpu=mips64 -target-abi=n32 < %s | FileCheck %s \
+; RUN:     -check-prefix=ALL -check-prefix=N32 -check-prefix=HARD-FLOAT
+; RUN: llc -march=mips64el -mcpu=mips64 -target-abi=n32 < %s | FileCheck %s \
+; RUN:     -check-prefix=ALL -check-prefix=N32 -check-prefix=HARD-FLOAT
+
+; RUN: llc -march=mips64 -mcpu=mips64 -target-abi=n64 < %s | FileCheck %s \
+; RUN:     -check-prefix=ALL -check-prefix=N64 -check-prefix=HARD-FLOAT
+; RUN: llc -march=mips64el -mcpu=mips64 -target-abi=n64 < %s | FileCheck %s \
+; RUN:     -check-prefix=ALL -check-prefix=N64 -check-prefix=HARD-FLOAT
+
+; RUN: llc -march=mips64 -mcpu=mips64 -mattr=+soft-float -target-abi=n32 < %s \
+; RUN: | FileCheck %s -check-prefix=ALL -check-prefix=N32 \
+; RUN:                -check-prefix=SOFT-FLOAT
+; RUN: llc -march=mips64el -mcpu=mips64 -mattr=+soft-float -target-abi=n32 < \
+; RUN:     %s | FileCheck %s -check-prefix=ALL -check-prefix=N32 \
+; RUN:                       -check-prefix=SOFT-FLOAT
+
+; RUN: llc -march=mips64 -mcpu=mips64 -mattr=+soft-float -target-abi=n64 < %s \
+; RUN: | FileCheck %s -check-prefix=ALL -check-prefix=N64 \
+; RUN:                -check-prefix=SOFT-FLOAT
+; RUN: llc -march=mips64el -mcpu=mips64 -mattr=+soft-float -target-abi=n64 < \
+; RUN:     %s | FileCheck %s -check-prefix=ALL -check-prefix=N64 \
+; RUN:                       -check-prefix=SOFT-FLOAT
+
+ at fp128 = global fp128 zeroinitializer
+
+define void @roundl_call(fp128 %value) {
+entry:
+; ALL-LABEL: roundl_call:
+; N32:          lw      $25, %call16(roundl)($gp)
+; N64:          ld      $25, %call16(roundl)($gp)
+
+; SOFT-FLOAT:   sd      $4, 8(${{[0-9]+}})
+; SOFT-FLOAT:   sd      $2, 0(${{[0-9]+}})
+
+; HARD-FLOAT:   sdc1    $f2, 8(${{[0-9]+}})
+; HARD-FLOAT:   sdc1    $f0, 0(${{[0-9]+}})
+
+  %call = call fp128 @roundl(fp128 %value)
+  store fp128 %call, fp128* @fp128
+  ret void
+}
+
+declare fp128 @roundl(fp128) nounwind readnone
Index: lib/Target/Mips/MipsCCState.cpp
===================================================================
--- lib/Target/Mips/MipsCCState.cpp
+++ lib/Target/Mips/MipsCCState.cpp
@@ -26,8 +26,8 @@
       "ceill",         "copysignl",    "cosl",          "exp2l",
       "expl",          "floorl",       "fmal",          "fmodl",
       "log10l",        "log2l",        "logl",          "nearbyintl",
-      "powl",          "rintl",        "sinl",          "sqrtl",
-      "truncl"};
+      "powl",          "rintl",        "roundl",        "sinl",
+      "sqrtl",         "truncl"};
 
   // Check that LibCalls is sorted alphabetically.
   auto Comp = [](const char *S1, const char *S2) { return strcmp(S1, S2) < 0; };


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D17760.49803.patch
Type: text/x-patch
Size: 2855 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20160304/f7015cd7/attachment.bin>


More information about the llvm-commits mailing list