[PATCH] D17867: [gold] Handle modules that are not included in the link.

Teresa Johnson via llvm-commits llvm-commits at lists.llvm.org
Thu Mar 3 16:14:40 PST 2016


tejohnson added a comment.

In http://reviews.llvm.org/D17867#367684, @rafael wrote:

> LGTM, but please wait for Teresa to comment on there being any interaction between getFunctionIndexForFile and --start-lib/--end-lib.


LGTM too. I reviewed PR26674, and it seems correct to me to handle this the same in getFunctionIndexForFile as in getModuleForFile. If we aren't including the object file in the link we don't care about any of its summary info.


Repository:
  rL LLVM

http://reviews.llvm.org/D17867





More information about the llvm-commits mailing list