[PATCH] D17871: [ELF] Generalize ELF symbol type handling

Davide Italiano via llvm-commits llvm-commits at lists.llvm.org
Thu Mar 3 15:31:43 PST 2016


davide added a comment.

Note (to future self and others): this minor yak was motivated by a bug I found.
Some symbols are not emitted in the symbol table with the appropriate type, e.g. STT_OBJECT. 
The current code logic would require passing another `bool isObject` around. Up to two additional argument, this stretching exercise was a little bit goofy but still acceptable, but with more types to support, is just too much, IMHO.


http://reviews.llvm.org/D17871





More information about the llvm-commits mailing list