[PATCH] D17738: [NVPTX] Fix function identifiers that are invalid in PTX and a bug fix for the case of name collisions.

Arpith Jacob via llvm-commits llvm-commits at lists.llvm.org
Thu Mar 3 14:01:07 PST 2016


arpith-jacob added a comment.

In http://reviews.llvm.org/D17738#367459, @rafael wrote:

> The real stable solution I think is for the IR name to be the final
>  name. No further mangling involved.


Correct me if I am wrong, but I think you are saying that the llvm IR name should only contain chars that are acceptable for *all* targets.

In this example, for valid ptx code, it's important that the period never appears in the IR name.

However, according to this patch <http://reviews.llvm.org/rL253804>:

> For globals it is important to use "foo.1" to help C++ name demangling.


So the two consumers have opposing constraints and the suggested approach cannot work?


http://reviews.llvm.org/D17738





More information about the llvm-commits mailing list